Messages in this thread Patch in this message | | | From | Sudip Mukherjee <> | Subject | [PATCH v2 1/2] usb: dwc2: gadget: modify return statement | Date | Thu, 16 Oct 2014 13:11:09 +0530 |
| |
modified the function to have a single return statement at the end instead of multiple return statement in the middle of the function to improve the readability of the code.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> --- drivers/usb/dwc2/gadget.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 7b5856f..af5517f 100644 --- a/drivers/usb/dwc2/gadget.c +++ b/drivers/usb/dwc2/gadget.c @@ -2471,7 +2471,8 @@ static int s3c_hsotg_ep_enable(struct usb_ep *ep, dir_in = (desc->bEndpointAddress & USB_ENDPOINT_DIR_MASK) ? 1 : 0; if (dir_in != hs_ep->dir_in) { dev_err(hsotg->dev, "%s: direction mismatch!\n", __func__); - return -EINVAL; + ret = -EINVAL; + goto error1; } mps = usb_endpoint_maxp(desc); @@ -2561,8 +2562,10 @@ static int s3c_hsotg_ep_enable(struct usb_ep *ep, hs_ep->fifo_size = val; break; } - if (i == 8) - return -ENOMEM; + if (i == 8) { + ret = -ENOMEM; + goto error1; + } } /* for non control endpoints, set PID to D0 */ @@ -2580,6 +2583,8 @@ static int s3c_hsotg_ep_enable(struct usb_ep *ep, s3c_hsotg_ctrl_epint(hsotg, index, dir_in, 1); spin_unlock_irqrestore(&hsotg->lock, flags); + +error1: return ret; } -- 1.8.1.2
| |