lkml.org 
[lkml]   [2014]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH -next 08/10] serial: core: Colocate crucial structure linkage
    Date
    The key function of uart_add_one_port() is to cross-reference the
    UART driver's port structure with the serial core's state table;
    keep the assignments together and document this crucial association.

    Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
    ---
    drivers/tty/serial/serial_core.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
    index 676c03a..e04ae58 100644
    --- a/drivers/tty/serial/serial_core.c
    +++ b/drivers/tty/serial/serial_core.c
    @@ -2594,11 +2594,12 @@ int uart_add_one_port(struct uart_driver *drv, struct uart_port *uport)
    goto out;
    }

    + /* Link the port to the driver state table and vice versa */
    state->uart_port = uport;
    - state->pm_state = UART_PM_STATE_UNDEFINED;
    + uport->state = state;

    + state->pm_state = UART_PM_STATE_UNDEFINED;
    uport->cons = drv->cons;
    - uport->state = state;

    /*
    * If this port is a console, then the spinlock is already
    --
    2.1.1


    \
     
     \ /
      Last update: 2014-10-16 23:41    [W:3.497 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site