lkml.org 
[lkml]   [2014]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP
On Thu, Oct 16, 2014 at 09:36:58AM -0400, Aristeu Rozanski wrote:
> (This time Cc'ing Johannes)

This kind of note shouldn't be in the commit-message portion of the
commit.

> It's desirable for allnconfig and tinyconfig targets to result in the
> least amount of code possible. DISABLE_DEV_COREDUMP exists as a way to
> switch off DEV_COREDUMP regardless if any drivers select
> WANT_DEV_COREDUMP.
>
> This patch renames the option to ENABLE_DEV_COREDUMP and setting it to
> 'n' (as in allnconfig or tinyconfig) will effectively disable device
> coredump.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Josh Triplett <josh@joshtriplett.org>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> Signed-off-by: Aristeu Rozanski <arozansk@redhat.com>

You should have a "---" line here, followed by a diffstat. If you're
not using git format-patch to format your patches, you should.

- Josh Triplett

> diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
> index 134f763..99d3072 100644
> --- a/drivers/base/Kconfig
> +++ b/drivers/base/Kconfig
> @@ -171,20 +171,23 @@ config WANT_DEV_COREDUMP
> Drivers should "select" this option if they desire to use the
> device coredump mechanism.
>
> -config DISABLE_DEV_COREDUMP
> - bool "Disable device coredump" if EXPERT
> +config ENABLE_DEV_COREDUMP
> + bool "Enable device coredump" if EXPERT
> + default y
> help
> - Disable the device coredump mechanism despite drivers wanting to
> - use it; this allows for more sensitive systems or systems that
> - don't want to ever access the information to not have the code,
> - nor keep any data.
> + This option controls if the device coredump mechanism is available or
> + not; if disabled, the mechanism will be omitted even if drivers that
> + can use it are enabled.
> + Say 'N' for more sensitive systems or systems that don't want
> + to ever access the information to not have the code, nor keep any
> + data.
>
> - If unsure, say N.
> + If unsure, say Y.
>
> config DEV_COREDUMP
> bool
> default y if WANT_DEV_COREDUMP
> - depends on !DISABLE_DEV_COREDUMP
> + depends on ENABLE_DEV_COREDUMP
>
> config DEBUG_DRIVER
> bool "Driver Core verbose debug messages"


\
 
 \ /
  Last update: 2014-10-16 16:22    [W:0.076 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site