Messages in this thread | | | Date | Thu, 16 Oct 2014 12:24:35 +0200 | From | Javier Martinez Canillas <> | Subject | Re: [PATCH 2/9] regulator: max77802: Add .{get,set}_mode callbacks |
| |
Hello Mark,
Thanks a lot for your feedback.
On 10/16/2014 10:36 AM, Mark Brown wrote: > On Wed, Oct 15, 2014 at 06:20:32PM +0200, Javier Martinez Canillas wrote: > >> +#define MAX77802_MODE(pval) ((pval == MAX77802_OPMODE_NORMAL) ? \ >> + REGULATOR_MODE_NORMAL : REGULATOR_MODE_STANDBY) >> + > > Make this a static inline function if there's any need for it, this is > both more legible and more helpful for the compiler. >
Ok, will change that.
>> + switch (mode) { >> + case REGULATOR_MODE_IDLE: >> + case REGULATOR_MODE_STANDBY: >> + val = MAX77802_OPMODE_LP; /* ON in Low Power Mode */ >> + break; > > You should never have multiple modes mapping onto a singel value - if > the user sets a mode they should find that the device has that mode. >
I see, thanks for the clarification. I think STANDBY better maps the device Low Power Mode according the description in include/linux/regulator/consumer.h so I'll just make IDLE invalid in v2.
Best regards, Javier
| |