Messages in this thread | | | Date | Thu, 16 Oct 2014 12:24:05 +0200 | From | Josh Triplett <> | Subject | Re: [PATCH] tiny: reverse logic for DISABLE_DEV_COREDUMP |
| |
On Thu, Oct 16, 2014 at 12:18:43PM +0200, Greg Kroah-Hartman wrote: > On Thu, Oct 16, 2014 at 05:51:58AM +0200, Josh Triplett wrote: > > On Thu, Oct 16, 2014 at 01:14:46AM +0200, Greg Kroah-Hartman wrote: > > > On Wed, Oct 15, 2014 at 11:25:23AM -0400, Aristeu Rozanski wrote: > > > > It's desirable for allnconfig and tinyconfig targets to result in the > > > > least amount of code possible. DISABLE_DEV_COREDUMP exists as a way to > > > > switch off DEV_COREDUMP regardless if any drivers select > > > > WANT_DEV_COREDUMP. > > > > > > > > This patch renames the option to ENABLE_DEV_COREDUMP and setting it to > > > > 'n' (as in allnconfig or tinyconfig) will effectively disable device > > > > coredump. > > > > > > > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > Cc: Josh Triplett <josh@joshtriplett.org> > > > > Reviewed-by: Josh Triplett <josh@joshtriplett.org> > > > > Signed-off-by: Aristeu Rozanski <arozansk@redhat.com> > > > > > > Any reason you didn't cc: the author of this feature / Kconfig option > > > about this change you are proposing? > > > > Likely my fault; I'd suggested using get_maintainer.pl, which does not > > show that for this patch: > > > > ~/src/linux$ scripts/get_maintainer.pl < /tmp/patch > > Greg Kroah-Hartman <gregkh@linuxfoundation.org> (supporter:DRIVER CORE, KOBJ...) > > linux-kernel@vger.kernel.org (open list) > > Yes, as that's just the Kconfig file, but at least let the person who > wrote that entry a chance to review it, that's just "being nice" :)
I agree; I'm just saying blame me rather than Aristeu. :)
- Josh Triplett
| |