lkml.org 
[lkml]   [2014]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] drivers/misc/eeprom/men_eeprod: Introduce MEN Board Information EEPROM driver
On Thu, Oct 16, 2014 at 10:15:08AM +0200, Andreas Werner wrote:
> Added driver to support the MEN Board Information EEPROM.
> The driver exports the production information as read only sysfs
> entries, as well as a user section which is read/write accessible.
>
> Tested on PPC QorIQ and Intel Atom E680.
>
> Tested-by: Johannes Thumshirn <johannes.thumshirn@men.de>
> Signed-off-by: Andreas Werner <andreas.werner@men.de>

I guess this is just a standard EEPROM with a well defined layout?
Why don't you want to use the standard driver then and parse the thing
in userspace?

Consider how bloated the sysfs-ABI might get if every vendor who uses an
eeprom wants to expose the data this way?

> +struct eeprom_data {
> + uint8_t eeprod_id;
> +
> + uint8_t revision[3];
> + uint32_t serialnr;
> + uint8_t board_model;
> + char hw_name[6];
> +
> + uint8_t reserved;
> +
> + __be16 prod_date;
> + __be16 rep_date;
> +
> + uint8_t reserved2[4];
> +};

And what if the compiler reorders?

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-10-16 11:21    [W:0.097 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site