lkml.org 
[lkml]   [2014]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm: vmscan: count only dirty pages as congested
On Wed, 15 Oct 2014 12:58:35 -0700 Jamie Liu <jamieliu@google.com> wrote:

> shrink_page_list() counts all pages with a mapping, including clean
> pages, toward nr_congested if they're on a write-congested BDI.
> shrink_inactive_list() then sets ZONE_CONGESTED if nr_dirty ==
> nr_congested. Fix this apples-to-oranges comparison by only counting
> pages for nr_congested if they count for nr_dirty.
>
> ...
>
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -875,7 +875,8 @@ static unsigned long shrink_page_list(struct list_head *page_list,
> * end of the LRU a second time.
> */
> mapping = page_mapping(page);
> - if ((mapping && bdi_write_congested(mapping->backing_dev_info)) ||
> + if (((dirty || writeback) && mapping &&
> + bdi_write_congested(mapping->backing_dev_info)) ||
> (writeback && PageReclaim(page)))
> nr_congested++;

What are the observed runtime effects of this change?


\
 
 \ /
  Last update: 2014-10-15 22:41    [W:0.062 / U:1.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site