Messages in this thread | | | Subject | Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings | From | Joe Perches <> | Date | Wed, 15 Oct 2014 13:03:49 -0700 |
| |
On Wed, 2014-10-15 at 22:53 +0300, Dan Carpenter wrote: > On Wed, Oct 15, 2014 at 09:11:36AM -0700, Joe Perches wrote: > > On Wed, 2014-10-15 at 06:03 -0700, Jeff Kirsher wrote: > > [] > > > I thought I remember Greg saying something about getting rid of this > > > driver anyway, but I could be wrong. If Greg decides to keep this > > > driver around, then I think we should something like your suggestion > > > above. > > > > Or maybe just make the Kconfig depend on X86_32 > > What I like about your patches is that they are pure theoretical work > and I don't have to think about them like regular proper patches with a > signed off by etc. All the fun, none of the responsibility.
I've sent a lot of signed-off patches. These are simple suggestions.
I think COMPILE_TEST isn't useful here.
I doubt very much beceem has been tested on anything other than an x86_32 board.
I once spent a few hours fixing up a bunch of defects in this directory a few years ago.
Now I will not submit any more patches for cmhost or anything else in that directory.
| |