lkml.org 
[lkml]   [2014]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] checkpatch: Add error on use of attribute((weak)) or __weak
On Wed, 15 Oct 2014 12:32:08 -0700 Joe Perches <joe@perches.com> wrote:

> Using weak can have unintended link defects.
> Emit an error on its use.

Well, we don't want a warning about use of __weak in function
definitions. Only in declarations.

> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -4671,6 +4671,14 @@ sub process {
> }
> }
>
> +# Check for __attribute__ weak, or __weak (may have link issues)
> + if ($realfile !~ m@\binclude/uapi/@ &&

And this bit maybe is checking for use in a header file, which is not
as good as checking for a declaration but is probably good enough.
However the "uapi" bit is confusing.

Can we have a better changelog please?

> + ($line =~ /\b__attribute__\s*\(\s*\(.*\bweak\b/ ||
> + $line =~ \b__weak\b/)) {
> + ERROR("AVOID_WEAK",
> + "Using weak can have unintended link defects" . $herecurr);
> + }
> +
> # check for sizeof(&)
> if ($line =~ /\bsizeof\s*\(\s*\&/) {
> WARN("SIZEOF_ADDRESS",
> --
> 2.1.0


\
 
 \ /
  Last update: 2014-10-15 22:21    [W:0.052 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site