Messages in this thread Patch in this message | | | From | Joe Perches <> | Subject | [PATCH 2/3] checkpatch: Add error on use of attribute((weak)) or __weak | Date | Wed, 15 Oct 2014 12:32:08 -0700 |
| |
Using weak can have unintended link defects. Emit an error on its use.
Signed-off-by: Joe Perches <joe@perches.com> --- scripts/checkpatch.pl | 8 ++++++++ 1 file changed, 8 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 696254e..692fdb6 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -4671,6 +4671,14 @@ sub process { } } +# Check for __attribute__ weak, or __weak (may have link issues) + if ($realfile !~ m@\binclude/uapi/@ && + ($line =~ /\b__attribute__\s*\(\s*\(.*\bweak\b/ || + $line =~ \b__weak\b/)) { + ERROR("AVOID_WEAK", + "Using weak can have unintended link defects" . $herecurr); + } + # check for sizeof(&) if ($line =~ /\bsizeof\s*\(\s*\&/) { WARN("SIZEOF_ADDRESS", -- 2.1.0
| |