Messages in this thread | | | Date | Wed, 15 Oct 2014 12:13:58 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] perf tools: fix incorrect header string |
| |
Em Wed, Oct 15, 2014 at 11:28:53AM +0800, Wang Nan escreveu: > Commit fbe96f29 (perf tools: Make perf.data more self-descriptive) > read '/proc/cpuinfo' to form cpu descriptor. For ARM, it finds > 'Processor' field. It is correct when the patch merged, but due to > commit b4b8f770 (ARM: kernel: update cpuinfo to print all online CPUs > features), the corresponding information becomes 'model name' field. > > This patch simply corrects it.
It doesn't :-)
It makes it work with kernels >= b4b8f770, and fail with older kernels.
We need to somehow figure out where the right information is regardless of the kernel.
- Arnaldo
> Signed-off-by: Wang Nan <wangnan0@huawei.com> > --- > tools/perf/perf-sys.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/perf-sys.h b/tools/perf/perf-sys.h > index 937e432..4293970 100644 > --- a/tools/perf/perf-sys.h > +++ b/tools/perf/perf-sys.h > @@ -113,7 +113,7 @@ > #define mb() ((void(*)(void))0xffff0fa0)() > #define wmb() ((void(*)(void))0xffff0fa0)() > #define rmb() ((void(*)(void))0xffff0fa0)() > -#define CPUINFO_PROC "Processor" > +#define CPUINFO_PROC "model name" > #endif > > #ifdef __aarch64__ > -- > 1.8.4
| |