Messages in this thread Patch in this message | | | From | Javier Martinez Canillas <> | Subject | [PATCH 1/1] ARM: EXYNOS: Call regulator core suspend prepare and finish functions | Date | Wed, 15 Oct 2014 14:01:36 +0200 |
| |
The regulator framework has a set of helpers functions to be used when the system is entering and leaving from suspend but these are not called on Exynos platforms. This means that the .set_suspend_* function handlers defined in regulator drivers are never called when the system is suspended.
Suggested-by: Doug Anderson <dianders@chromium.org> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> --- arch/arm/mach-exynos/suspend.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
diff --git a/arch/arm/mach-exynos/suspend.c b/arch/arm/mach-exynos/suspend.c index f5d9773..5b9c551 100644 --- a/arch/arm/mach-exynos/suspend.c +++ b/arch/arm/mach-exynos/suspend.c @@ -20,6 +20,7 @@ #include <linux/io.h> #include <linux/irqchip/arm-gic.h> #include <linux/err.h> +#include <linux/regulator/machine.h> #include <asm/cacheflush.h> #include <asm/hardware/cache-l2x0.h> @@ -270,14 +271,29 @@ static int exynos_suspend_enter(suspend_state_t state) static int exynos_suspend_prepare(void) { + int ret; + s3c_pm_check_prepare(); + /* + * REVISIT: It would be better if struct platform_suspend_ops + * .prepare handler get the suspend_state_t as a parameter to + * avoid hard-coding the suspend to mem state. It's safe to do + * it only because the suspend_valid_only_mem function is the + * .valid callback used to check if a given state is supported + * by the platform. + */ + ret = regulator_suspend_prepare(PM_SUSPEND_MEM); + if (ret) + pr_info("Failed to prepare regulators for system suspend\n"); + return 0; } static void exynos_suspend_finish(void) { s3c_pm_check_cleanup(); + regulator_suspend_finish(); } static const struct platform_suspend_ops exynos_suspend_ops = { -- 2.1.0
| |