Messages in this thread | | | Date | Tue, 14 Oct 2014 19:08:43 -0400 | From | Sasha Levin <> | Subject | Re: [PATCH 2/2] mm: verify compound order when freeing a page |
| |
On 10/14/2014 04:29 PM, David Cohen wrote: >> + VM_BUG_ON(PageTail(page)); >> > + VM_BUG_ON(PageHead(page) && compound_order(page) != order); > It may be too severe. AFAIU we're not talking about a fatal error. > How about VM_WARN_ON()?
VM_BUG_ON() should catch anything which is not "supposed" to happen, and not just the severe stuff. Unlike BUG_ON, VM_BUG_ON only gets hit with mm debugging enabled.
Thanks, Sasha
| |