Messages in this thread |  | | Date | Tue, 14 Oct 2014 15:59:35 -0700 | From | Dmitry Torokhov <> | Subject | Re: [PATCH] HID: i2c-hid: Add hid-over-i2c name to i2c id table. |
| |
On Tue, Oct 14, 2014 at 02:44:01PM -0700, Benson Leung wrote: > When using the device tree binding of compatible = "hid-over-i2c" > the i2c id table also needs to have that name in order to > auto load this driver. > > Signed-off-by: Benson Leung <bleung@chromium.org> > --- > drivers/hid/i2c-hid/i2c-hid.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c > index 747d544..1a7605f 100644 > --- a/drivers/hid/i2c-hid/i2c-hid.c > +++ b/drivers/hid/i2c-hid/i2c-hid.c > @@ -1123,6 +1123,7 @@ static const struct dev_pm_ops i2c_hid_pm = { > > static const struct i2c_device_id i2c_hid_id_table[] = { > { "hid", 0 }, > + { "hid-over-i2c", 0 }, > { }, > }; > MODULE_DEVICE_TABLE(i2c, i2c_hid_id_table);
So we already emit this string this as a module device table (OF one), why do we need to duplicate it in I2C? This seems like a generic problem and not an individual driver one.
Thanks.
-- Dmitry
|  |