Messages in this thread | | | Date | Tue, 14 Oct 2014 15:43:49 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 1/1] fallocate: create FAN_MODIFY and IN_MODIFY events |
| |
On Tue, 07 Oct 2014 20:24:02 +0200 Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> Hello Andrew, > > the patch in > https://lkml.org/lkml/2014/10/3/56 > and cited below was reviewed by Jan Kara. >
Jan wondered why we generate events for FALLOC_FL_KEEP_SIZE, so other people will wonder the same thing. We should tell them. Via code comments and/or changelogging.
Any question which a reviewer asks should be viewed as a defect in the patch. The patch isn't finished until people can read it without having questions.
| |