lkml.org 
[lkml]   [2014]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] gcov: add ARM64 to GCOV_PROFILE_ALL
Hi Andrew,

On Tue, 14 Oct 2014 14:40:48 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
>
> > > diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig
> > > index cf66c5c..3b74087 100644
> > > --- a/kernel/gcov/Kconfig
> > > +++ b/kernel/gcov/Kconfig
> > > @@ -35,7 +35,7 @@ config GCOV_KERNEL
> > > config GCOV_PROFILE_ALL
> > > bool "Profile entire Kernel"
> > > depends on GCOV_KERNEL
> > > - depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM
> > > + depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM || ARM64
> > > default n
> > > ---help---
> > > This options activates profiling for the entire kernel.
>
> gcov is doing this the wrong way. There should be a `select
> GCOV_PROFILE_ALL' in each arch/*/Kconfig.

What they should actually do is select (say) ARCH_HAS_GCOV_PROFILE_ALL
and then GCOV_PROFILE_ALL should depend on that.

--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-10-15 00:21    [W:2.959 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site