Messages in this thread | | | Date | Wed, 15 Oct 2014 08:54:34 +1100 | From | Stephen Rothwell <> | Subject | Re: [PATCH] gcov: add ARM64 to GCOV_PROFILE_ALL |
| |
Hi Andrew,
On Tue, 14 Oct 2014 14:40:48 -0700 Andrew Morton <akpm@linux-foundation.org> wrote: > > > > diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig > > > index cf66c5c..3b74087 100644 > > > --- a/kernel/gcov/Kconfig > > > +++ b/kernel/gcov/Kconfig > > > @@ -35,7 +35,7 @@ config GCOV_KERNEL > > > config GCOV_PROFILE_ALL > > > bool "Profile entire Kernel" > > > depends on GCOV_KERNEL > > > - depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM > > > + depends on SUPERH || S390 || X86 || PPC || MICROBLAZE || ARM || ARM64 > > > default n > > > ---help--- > > > This options activates profiling for the entire kernel. > > gcov is doing this the wrong way. There should be a `select > GCOV_PROFILE_ALL' in each arch/*/Kconfig.
What they should actually do is select (say) ARCH_HAS_GCOV_PROFILE_ALL and then GCOV_PROFILE_ALL should depend on that.
-- Cheers, Stephen Rothwell sfr@canb.auug.org.au [unhandled content-type:application/pgp-signature] | |