Messages in this thread | | | Date | Tue, 14 Oct 2014 16:24:38 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH v2] perf tools: fix off-by-one error in maps |
| |
Em Tue, Oct 14, 2014 at 09:03:02PM +0200, Stephane Eranian escreveu: > On Tue, Oct 14, 2014 at 8:58 PM, Arnaldo Carvalho de Melo > > struct vm_area_struct { > > /* The first cache line has the info for VMA tree walking. */
> > unsigned long vm_start; /* Our start address within vm_mm. */ > > unsigned long vm_end; /* The first byte after our end address > > within vm_mm. */
> > So these guys have been doing this far longer than me, I guess I'll bow > > to this convention.
> > But by renaming map->end to map->end_ and looking at all the usage of > > it, there are some inconsistencies...
> > Like symbol->{start,end} is of the [start,end] case, and to be > > consistent with above needs to also move to [start,end[, will cook a > > patch and send for review.
> Yes, there were some inconsistencies (or confusions) that I noticed when > I started fixing the maps. I can believe that this off-by-one error exist with > other data types. That could cause wrong symbol correlations in borderline > cases (which are really rare).
Yeah, I'll try and fix one by one in separate patches when applicable.
- Arnaldo
| |