Messages in this thread | | | Subject | Re: [PATCH 1/1 linux-next] fs/jffs2/nodelist.h: remove unnecessary __constant_ prefix | From | Joe Perches <> | Date | Tue, 14 Oct 2014 09:52:37 -0700 |
| |
On Tue, 2014-10-14 at 18:44 +0200, Fabian Frederick wrote: > See commit fbdb8138cf0c > ("checkpatch: warn on uses of __constant_<foo> functions")
Perhaps it'd be better to use the same __builtin_constant_p test as swab.h and use just one pattern instead
> diff --git a/fs/jffs2/nodelist.h b/fs/jffs2/nodelist.h > index fa35ff7..9f0d547 100644 > --- a/fs/jffs2/nodelist.h > +++ b/fs/jffs2/nodelist.h > @@ -48,8 +48,8 @@ > #define cpu_to_je32(x) ((jint32_t){cpu_to_be32(x)}) > #define cpu_to_jemode(x) ((jmode_t){cpu_to_be32(os_to_jffs2_mode(x))}) > > -#define constant_cpu_to_je16(x) ((jint16_t){__constant_cpu_to_be16(x)}) > -#define constant_cpu_to_je32(x) ((jint32_t){__constant_cpu_to_be32(x)}) > +#define constant_cpu_to_je16(x) ((jint16_t){cpu_to_be16(x)}) > +#define constant_cpu_to_je32(x) ((jint32_t){cpu_to_be32(x)})
So none of these constant_<foo> things would be here at all.
| |