lkml.org 
[lkml]   [2014]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 3/5] fuse: Restrict allow_other to uids already controlled by the user
    Date
    Unprivileged users are normally restricted from mounting with the
    allow_other option by system policy, but this could be bypassed
    for a mount done with user namespace root permissions. In such
    cases allow_other should not allow users outside the user
    namespace to access the mount as doing so would give the
    unprivileged user the ability to manipulate processes it would
    otherwise be unable to manipulate.

    Cc: Eric W. Biederman <ebiederm@xmission.com>
    Cc: Serge H. Hallyn <serge.hallyn@ubuntu.com>
    Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
    ---
    fs/fuse/dir.c | 16 ++++++++++++----
    1 file changed, 12 insertions(+), 4 deletions(-)

    diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
    index 123db1e06c78..e3123bfbc711 100644
    --- a/fs/fuse/dir.c
    +++ b/fs/fuse/dir.c
    @@ -1089,12 +1089,20 @@ int fuse_reverse_inval_entry(struct super_block *sb, u64 parent_nodeid,
    */
    int fuse_allow_current_process(struct fuse_conn *fc)
    {
    - const struct cred *cred;
    + const struct cred *cred = current_cred();

    - if (fc->flags & FUSE_ALLOW_OTHER)
    - return 1;
    + if (fc->flags & FUSE_ALLOW_OTHER) {
    + if (kuid_has_mapping(fc->user_ns, cred->euid) &&
    + kuid_has_mapping(fc->user_ns, cred->suid) &&
    + kuid_has_mapping(fc->user_ns, cred->uid) &&
    + kgid_has_mapping(fc->user_ns, cred->egid) &&
    + kgid_has_mapping(fc->user_ns, cred->sgid) &&
    + kgid_has_mapping(fc->user_ns, cred->gid))
    + return 1;
    +
    + return 0;
    + }

    - cred = current_cred();
    if (uid_eq(cred->euid, fc->user_id) &&
    uid_eq(cred->suid, fc->user_id) &&
    uid_eq(cred->uid, fc->user_id) &&
    --
    2.1.0


    \
     
     \ /
      Last update: 2014-10-14 17:01    [W:2.884 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site