Messages in this thread | | | Date | Tue, 14 Oct 2014 14:40:09 +0200 | From | Lars-Peter Clausen <> | Subject | Re: [RESEND PATCH v2 1/4] dmaengine: pl330: Remove non-NULL check for pl330_submit_req parameters |
| |
On 10/14/2014 01:51 PM, Vinod Koul wrote: > On Mon, Sep 29, 2014 at 02:42:18PM +0200, Krzysztof Kozlowski wrote: >> The pl330_submit_req() checked supplied 'struct pl330_thread thrd' and >> 'struct dma_pl330_desc desc' parameters for non-NULL. However these >> checks are useless because supplied arguments won't be NULL. > even if we have some error or bug? > > I would like this to be checked and complained loudly so we know something > is going wrong rather than assuming it will be correct always. >
In this case it is impossible to get to this code portion if the pointer is NULL because it would have crashed earlier.
- Lars
| |