lkml.org 
[lkml]   [2014]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH v4 19/25] virtio_console: enable VQs early on restore
    virtio spec requires drivers to set DRIVER_OK before using VQs.
    This is set automatically after resume returns, virtio console violated this
    rule by adding inbufs, which causes the VQ to be used directly within
    restore.

    To fix, call virtio_device_ready before using VQs.

    Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    ---
    drivers/char/virtio_console.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
    index 6ebe8f6..2ae843f 100644
    --- a/drivers/char/virtio_console.c
    +++ b/drivers/char/virtio_console.c
    @@ -2184,6 +2184,8 @@ static int virtcons_restore(struct virtio_device *vdev)
    if (ret)
    return ret;

    + virtio_device_ready(portdev->vdev);
    +
    if (use_multiport(portdev))
    fill_queue(portdev->c_ivq, &portdev->c_ivq_lock);

    --
    MST



    \
     
     \ /
      Last update: 2014-10-13 10:22    [W:4.381 / U:0.352 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site