Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] modules, lock around setting of MODULE_STATE_UNFORMED | Date | Mon, 13 Oct 2014 16:11:26 +1030 |
| |
Oleg Nesterov <oleg@redhat.com> writes: > On 10/08, Prarit Bhargava wrote: >> >> --- a/kernel/module.c >> +++ b/kernel/module.c >> @@ -1842,7 +1842,9 @@ static void free_module(struct module *mod) >> >> /* We leave it in list to prevent duplicate loads, but make sure >> * that noone uses it while it's being deconstructed. */ >> + mutex_lock(&module_mutex); >> mod->state = MODULE_STATE_UNFORMED; >> + mutex_unlock(&module_mutex); >> >> /* Remove dynamic debug info */ >> ddebug_remove_module(mod->name); > > Reviewed-by: Oleg Nesterov <oleg@redhat.com>
Thanks, good catch.
I've cc'd stable too.
Cheers, Rusty.
| |