lkml.org 
[lkml]   [2014]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] block: update locking context for blk_free_devt
On 2014-10-13 12:35, Dmitry Monakhov wrote:
> After 2da78092 this function will not longer sleepy
>
> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
> ---
> block/genhd.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/block/genhd.c b/block/genhd.c
> index 09da5e4..ae9aaa5 100644
> --- a/block/genhd.c
> +++ b/block/genhd.c
> @@ -441,12 +441,10 @@ int blk_alloc_devt(struct hd_struct *part, dev_t *devt)
> * Free @devt which was allocated using blk_alloc_devt().
> *
> * CONTEXT:
> - * Might sleep.
> + * Don't care.
> */
> void blk_free_devt(dev_t devt)
> {
> - might_sleep();
> -
> if (devt == MKDEV(0, 0))
> return;

What's this against? The might_sleep() was killed about a month ago by
commit 46f341ffcfb5. The comment wasn't updated though, it should be.

--
Jens Axboe



\
 
 \ /
  Last update: 2014-10-13 23:01    [W:0.035 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site