Messages in this thread Patch in this message | | | From | Fabian Frederick <> | Subject | [PATCH 1/1 linux-next] scripts/checkpatch.pl: fix k[mz]alloc with multiplies check | Date | Mon, 13 Oct 2014 22:06:42 +0200 |
| |
checkpatch doesn't seem to detect any case since
Commit e367455a9f25 ("checkpatch: emit fewer kmalloc_array/kcalloc conversion warnings")
Cc: Joe Perches <joe@perches.com> Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Fabian Frederick <fabf@skynet.be> --- scripts/checkpatch.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 374abf4..e18afcd 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -4875,8 +4875,8 @@ sub process { $r1 = $a2; $r2 = $a1; } - if ($r1 !~ /^sizeof\b/ && $r2 =~ /^sizeof\s*\S/ && - !($r1 =~ /^$Constant$/ || $r1 =~ /^[A-Z_][A-Z0-9_]*$/)) { + if ($r1 !~ /^sizeof\b/ && !($r2 =~ /^sizeof\s*\S/ && + ($r1 =~ /^$Constant$/ || $r1 =~ /^[A-Z_][A-Z0-9_]*$/))) { if (WARN("ALLOC_WITH_MULTIPLY", "Prefer $newfunc over $oldfunc with multiply\n" . $herecurr) && $fix) { -- 1.9.3
| |