[lkml]   [2014]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] tty/serial_core: Introduce lock mechanism for RS485
Hello Alan

>> + spin_unlock_irqrestore(&port->lock, flags);
> Looks good apart from this bit.. The copy needs to go to a temporary
> before the lock is taken otherwise we may sleep on a pagefault with irqs
> off
> Alan

Good catch

I will fix it as you suggest.

I will give a give a couple of days for comments about the serie
"[PATCH 00/12] Handle TIOC[GS]RS485
iocts on serial_core" Then I will resend the series including this
patch (of course, fixed)


Ricardo Ribalda

 \ /
  Last update: 2014-10-13 21:41    [W:0.072 / U:1.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site