Messages in this thread | | | Date | Mon, 13 Oct 2014 18:16:10 +0200 | Subject | Re: [PATCH] [media] s5p-jpeg: Only build suspend/resume for PM | From | Geert Uytterhoeven <> |
| |
On Thu, Oct 2, 2014 at 9:21 AM, Thierry Reding <thierry.reding@gmail.com> wrote: > From: Thierry Reding <treding@nvidia.com> > > If power management is disabled these function become unused, so there > is no reason to build them. This fixes a couple of build warnings when > PM(_SLEEP,_RUNTIME) is not enabled.
Thanks!
Despite the availability of your patch, this build warning has migrated to mainline.
> Signed-off-by: Thierry Reding <treding@nvidia.com>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> --- a/drivers/media/platform/s5p-jpeg/jpeg-core.c > +++ b/drivers/media/platform/s5p-jpeg/jpeg-core.c
> @@ -2681,7 +2682,9 @@ static int s5p_jpeg_runtime_resume(struct device *dev) > > return 0; > } > +#endif
I'd add a comment "/* CONFIG_PM_RUNTIME || CONFIG_PM_SLEEP */" here, as above is a big block of code.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |