lkml.org 
[lkml]   [2014]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tty/serial_core: Introduce lock mechanism for RS485
> @@ -1154,8 +1154,16 @@ static int uart_get_icount(struct tty_struct *tty,
> static int uart_get_rs485_config(struct uart_port *port,
> struct serial_rs485 __user *rs485)
> {
> - if (copy_to_user(rs485, &port->rs485, sizeof(port->rs485)))
> + unsigned long flags;
> + int ret;
> +
> + spin_lock_irqsave(&port->lock, flags);
> + ret = copy_to_user(rs485, &port->rs485, sizeof(port->rs485));
> + spin_unlock_irqrestore(&port->lock, flags);

Looks good apart from this bit.. The copy needs to go to a temporary
before the lock is taken otherwise we may sleep on a pagefault with irqs
off

Alan


\
 
 \ /
  Last update: 2014-10-13 16:21    [W:0.054 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site