Messages in this thread | | | Subject | Re: [PATCH] staging: rtl8188eu: Fix coding style space related ERROR problems | From | Joe Perches <> | Date | Mon, 13 Oct 2014 02:13:05 -0700 |
| |
On Mon, 2014-10-13 at 16:47 +0800, Jia He wrote: > This fixes space related ERROR reports by checkpatch.pl > Generated by $ git ls-files "drivers/staging/rtl8188eu/*.[ch]" | \ > xargs ./scripts/checkpatch.pl -f --fix-inplace --strict --types=SPACING
checkpatch isn't perfect.
Always verify the output before submitting automated changes.
> diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8188eu/core/rtw_xmit.c [] > @@ -772,7 +772,7 @@ static s32 xmitframe_swencrypt(struct adapter *padapter, struct xmit_frame *pxmi > return _SUCCESS; > } > > -s32 rtw_make_wlanhdr (struct adapter *padapter , u8 *hdr, struct pkt_attrib *pattrib) > +s32 rtw_make_wlanhdr(struct adapter *padapter , u8 *hdr, struct pkt_attrib *pattrib)
The space after padapter should be removed.
> diff --git a/drivers/staging/rtl8188eu/hal/bb_cfg.c b/drivers/staging/rtl8188eu/hal/bb_cfg.c
> @@ -552,7 +552,7 @@ static void store_pwrindex_offset(struct adapter *Adapter, u32 regaddr, u32 bitm > } > } > > -static void rtl_addr_delay(struct adapter *adapt, u32 addr, u32 bit_mask ,u32 data) > +static void rtl_addr_delay(struct adapter *adapt, u32 addr, u32 bit_mask , u32 data)
likewise, the space after bit_mask too
> diff --git a/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c b/drivers/staging/rtl8188eu/os_dep/ioctl_linux.c [] > @@ -2059,7 +2059,7 @@ static int wpa_supplicant_ioctl(struct net_device *dev, struct iw_point *p) > struct ieee_param *param; > uint ret = 0; > > - if (p->length < sizeof(struct ieee_param) || !p->pointer) { > + if (p->length < sizeof(struct ieee_param)|| !p->pointer) {
checkpatch defect, nothing wrong with original.
| |