lkml.org 
[lkml]   [2014]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.17 18/25] Revert "usb: gadget: composite: dequeue cdev->req before free it in composite_dev_cleanup"
    Date
    3.17-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Felipe Balbi <balbi@ti.com>

    commit bf17eba7ae1e813b0ad67cb1078dcbd7083b906e upstream.

    This reverts commit f2267089ea17fa97b796b1b4247e3f8957655df3.

    That commit causes more problem than fixes. Firstly, kfree()
    should be called after usb_ep_dequeue() and secondly, the way
    things are, we will try to dequeue a request that has already
    completed much more frequently than one which is pending.

    Cc: Li Jun <b47624@freescale.com>
    Signed-off-by: Felipe Balbi <balbi@ti.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/gadget/composite.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/drivers/usb/gadget/composite.c
    +++ b/drivers/usb/gadget/composite.c
    @@ -1956,7 +1956,6 @@ void composite_dev_cleanup(struct usb_co
    }
    if (cdev->req) {
    kfree(cdev->req->buf);
    - usb_ep_dequeue(cdev->gadget->ep0, cdev->req);
    usb_ep_free_request(cdev->gadget->ep0, cdev->req);
    }
    cdev->next_string_id = 0;



    \
     
     \ /
      Last update: 2014-10-13 05:02    [W:4.199 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site