lkml.org 
[lkml]   [2014]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/5] fs/anon_inodes.c: Simplify control flow in anon_inode_getfd()
On Sun, Oct 12, 2014 at 03:42:39PM -0500, Eric Biggers wrote:

> file = anon_inode_getfile(name, fops, priv, flags);
> if (IS_ERR(file)) {
> - error = PTR_ERR(file);
> - goto err_put_unused_fd;
> + put_unused_fd(fd);
> + return PTR_ERR(file);
> }
> fd_install(fd, file);

at least slap unlikely() on that if (IS_ERR(...))...


\
 
 \ /
  Last update: 2014-10-12 23:41    [W:0.347 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site