Messages in this thread | | | Date | Sun, 12 Oct 2014 10:03:32 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH] vfs: Deduplicate code shared by xattr system calls operating on paths |
| |
On Sun, Oct 12, 2014 at 11:59:58AM -0500, Eric Biggers wrote: > The following pairs of system calls dealing with extended attributes only > differ in their behavior on whether the symbolic link is followed (when > the named file is a symbolic link): > > - setxattr() and lsetxattr() > - getxattr() and lgetxattr() > - listxattr() and llistxattr() > - removexattr() and lremovexattr() > > Despite this, the implementations all had duplicated code, so this commit > redirects each of the above pairs of system calls to a corresponding > function to which different lookup flags (LOOKUP_FOLLOW or 0) are passed. > > For me this reduced the stripped size of xattr.o from 8824 to 8248 bytes.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |