Messages in this thread | | | Date | Sun, 12 Oct 2014 11:53:32 -0500 | From | Chuck Ebbert <> | Subject | Re: [PATCH] x86: Clean up stack access code in irq_32.c |
| |
On Sun, 12 Oct 2014 09:47:53 -0700 "H. Peter Anvin" <hpa@zytor.com> wrote:
[replying to the list this time, sigh]
> We changed this to asm because the C broke some compilers. Why are you changing it back? >
The C broke some compilers because it was using a global register variable. This is a local one, which the clang documentation says is supported. And I compiled it with clang with no problem.
> On October 12, 2014 9:43:53 AM PDT, Chuck Ebbert <cebbert.lkml@gmail.com> wrote: > >Use C instead of asm for accessing the stack pointer. And define some > >macros to make the code easier to understand. > >
| |