Messages in this thread | | | Date | Sat, 11 Oct 2014 19:25:18 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH] char: hw_random: core.c: Changed from using strncpy to strlcpy |
| |
On Sat, Oct 11, 2014 at 07:11:22PM -0700, Guenter Roeck wrote: > On Sat, Oct 11, 2014 at 05:27:41PM -0700, Mark D Rustad wrote: > > On Oct 11, 2014, at 3:36 PM, Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> wrote: > > > > > Changed from using strncpy to strlcpy to simplify the code > > > > Actually you changed from using strncat to strlcat. > > > ... and changed the length parameter along the way, making the length check > overall quite worthless and introducing a _real_ problem. > Me talking nonsense; ignore this noise.
Guenter
| |