Messages in this thread Patch in this message |  | | Subject | Re: [PATCH v2 1/2] kconfig: fix bad syntactic transformation in expr.c | From | Paul Bolle <> | Date | Sat, 11 Oct 2014 21:07:23 +0200 |
| |
On Mon, 2014-09-22 at 19:13 +0200, Martin Walch wrote: > Fix it by removing expr_eliminate_dups2() and the functions that have no use > anywhere else: expr_extract_eq_and(), expr_extract_eq_or(), > and expr_extract_eq() from scripts/kconfig/expr.[ch] > > Currently the bug is not triggered in mainline, so this patch does not modify > the configuration space there.
Would I be whining if I'd complained about the lack of documentation for expr_eliminate_dups(), expr_eliminate_dups1(), and expr_eliminate_dups2()?
So, I've put in these two calls of fprintf(): @@ -579,6 +606,7 @@ static void expr_eliminate_dups2(enum expr_type type, struct expr **ep1, struct tmp2 = expr_copy(e2); tmp = expr_extract_eq_and(&tmp1, &tmp2); if (expr_is_yes(tmp1)) { + fprintf(stderr, "%s:%d:\n", __func__, __LINE__); expr_free(e1); e1 = expr_alloc_symbol(&symbol_no); trans_count++; @@ -594,6 +622,7 @@ static void expr_eliminate_dups2(enum expr_type type, struct expr **ep1, struct tmp2 = expr_copy(e2); tmp = expr_extract_eq_or(&tmp1, &tmp2); if (expr_is_no(tmp1)) { + fprintf(stderr, "%s:%d:\n", __func__, __LINE__); expr_free(e1); e1 = expr_alloc_symbol(&symbol_yes); trans_count++; None of the 500+ defconfig files in next-20141010 triggered those fprintf's.
Does that means it's likely that nothing in next-20141010 actually uses the functionality expr_eliminate_dups2() provides?
Paul Bolle
|  |