Messages in this thread | | | Subject | Re: [PATCH] char: misc: use pr_err instead of printk | From | Joe Perches <> | Date | Sat, 11 Oct 2014 11:35:41 -0700 |
| |
On Sun, 2014-10-12 at 00:01 +0530, Rahul Bedarkar wrote: [] > diff --git a/drivers/char/misc.c b/drivers/char/misc.c [] > @@ -280,12 +280,12 @@ static int __init misc_init(void) > > err = -EIO; > if (register_chrdev(MISC_MAJOR,"misc",&misc_fops)) > - goto fail_printk; > + goto fail_pr_err; > misc_class->devnode = misc_devnode; > return 0; > > -fail_printk: > - printk("unable to get major %d for misc devices\n", MISC_MAJOR); > +fail_pr_err: > + pr_err("unable to get major %d for misc devices\n", MISC_MAJOR); > class_destroy(misc_class); > fail_remove: > remove_proc_entry("misc", NULL);
The printk is not relevant. Maybe the label should be "fail_destroy:"
| |