lkml.org 
[lkml]   [2014]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3 2/6] ARM: dts: rockchip: use the same pmu node name as before
Date
Am Freitag, 10. Oktober 2014, 14:26:06 schrieb Kever Yang:
> We use the "rockchip,rk3066-pmu" for rk3288 instead of creat
> a new one.

No, it should stay keep the rk3288-pmu compatible. While the 4 powerdomains
for the cores are similar, the pmu in general is very much specific to the
rk3288.

Also, this renaming of the pmu compatible only is a workaround for the
underlying problem, that your tree is probably missing the early syscon
support and there falling back to mapping the node directly.

If you apply the patch
[PATCH v7] mfd: syscon: Decouple syscon interface from platform devices
to your tree, it will work as expected by really using the pmu reference from
patch3 - it did for me - making this patch unnecessary.


Heiko

>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>
> Changes in v3:
> - add this patch in version 3
>
> Changes in v2: None
>
> arch/arm/boot/dts/rk3288.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index 874e66d..06f39be 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -440,7 +440,7 @@
> };
>
> pmu: power-management@ff730000 {
> - compatible = "rockchip,rk3288-pmu", "syscon";
> + compatible = "rockchip,rk3066-pmu", "syscon";
> reg = <0xff730000 0x100>;
> };



\
 
 \ /
  Last update: 2014-10-11 20:21    [W:0.092 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site