[lkml]   [2014]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC] drop owner assignment from platform_drivers

> > You got me wondering, though, that it could not be correct to call
> > platform_driver_register() from the platform core instead of module
> > init. I will check tomorrow. Still, this would be a bug independent of
> > my series. Although I'd need to respin it if platform_driver_probe()
> > needed a fix.
> Right, this seems to be a preexisting bug. platform_create_bundle
> and platform_driver_probe will both overwrite the .owner field with
> NULL since they live in builtin code. They need to be replaced with
> __platform_driver_probe and __platform_driver_register that both
> take an extra owner argument passed down from the caller in the driver
> module.

Yeah, that would be one solution. However, my personal favourite would
meanwhile be to revert the commit that Russell mentioned. I think it is
cleaner to have the owner explicitly set in the module rather than
hidden away by a function call. However, grepping through include/linux,
there are a few subsystems hiding it this way. So, it is a pattern
somewhow. Oh well...

[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2014-10-11 19:41    [W:0.051 / U:1.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site