Messages in this thread | | | Date | Sat, 11 Oct 2014 18:11:02 +0800 | From | Fengwei Yin <> | Subject | Re: [PATCH] smaps should deal with huge zero page exactly same as normal zero page |
| |
On Fri, Oct 10, 2014 at 07:35:15AM -0700, Dave Hansen wrote: > On 10/10/2014 06:21 AM, Fengwei Yin wrote: > > @@ -787,6 +788,9 @@ check_pfn: > > return NULL; > > } > > > > + if (is_huge_zero_pfn(pfn)) > > + return NULL; > > + > > That looks a lot better. One thing, why not put the is_huge_zero_pfn() > check next to the is_zero_pfn() check?
On the arch which has PTE_SPECIAL feaure, we need to make sure the is_huge_zero_pfn() is called after the pfn is checked if !pte_special().
| |