Messages in this thread |  | | Date | Fri, 10 Oct 2014 09:01:42 +0200 | From | Thierry Reding <> | Subject | Re: [PATCH 1/2] ARM: tegra: venice2: add GK20A GPU DT node |
| |
On Thu, Oct 09, 2014 at 10:10:29PM -0700, Stephen Warren wrote: > On 10/08/2014 11:11 PM, Alexandre Courbot wrote: > > From: Thierry Reding <treding@nvidia.com> > > > > Add the device-tree node for the GK20A GPU and leave it disabled by > > default. It is the responsability of the bootloader to enable it if the > > VPR registers have been programmed such as the GPU can operate. > > > diff --git a/arch/arm/boot/dts/tegra124-venice2.dts b/arch/arm/boot/dts/tegra124-venice2.dts > > > + gpu@0,57000000 { > > + status = "disabled"; > > status="disabled" usually goes into tegra124.dtsi. A board would only > override status to "okay" if necessary, and include any board specific > properties ...
True. I guess this is somewhat redundant here since the .dtsi file already sets it to "disabled". Given how it is rather unusual for a board's DTS file to not enable a node I think there would be some advantage in keeping this explicitly to avoid confusion. Alternatively perhaps a comment in the DTS file about why this isn't enabled by default would be a good replacement.
Thierry [unhandled content-type:application/pgp-signature] |  |