Messages in this thread | | | From | Vincent Guittot <> | Date | Fri, 10 Oct 2014 16:38:06 +0200 | Subject | Re: [PATCH v7 5/7] sched: get CPU's usage statistic |
| |
On 9 October 2014 17:12, Peter Zijlstra <peterz@infradead.org> wrote:
>> >> +static int get_cpu_usage(int cpu) >> >> +{ >> >> + unsigned long usage = cpu_rq(cpu)->cfs.utilization_load_avg; >> >> + unsigned long capacity = capacity_orig_of(cpu); >> >> + >> >> + if (usage >= SCHED_LOAD_SCALE) >> >> + return capacity + 1; >> > >> > Like Morten I'm confused by that +1 thing. >> >> ok. the goal was to point out the erroneous case where usage is out of >> the range but if it generates confusion, it can remove it > > Well, the fact that you clip makes that point, returning a value outside > of the specified range doesn't.
i meant removing the +1
| |