lkml.org 
[lkml]   [2014]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH V4 5/7] ARM: dts: Enable Broadcom Cygnus SoC
Date
On Thursday 09 October 2014 15:44:29 Scott Branden wrote:
> +
> + lcpll: lcpll@0301d02c {
> + #clock-cells = <0>;
> + compatible = "brcm,cygnus-lcpll-clk";
> + reg = <0x0301d02c 0x1c>;
> + clocks = <&osc>;
> + };
> +
> + genpll: genpll@0301d000 {
> + #clock-cells = <0>;
> + compatible = "brcm,cygnus-genpll-clk";
> + reg = <0x0301d000 0x2c>,
> + <0x180AA024 0x4>,
> + <0x0301C020 0x4>;
> + clocks = <&osc>;
> + };
> +

To be honest, I'm not too happy about the way you specify a single
register for each clock as a global 'reg' property.

Presumably each of these registers is part of an IP block that does
multiple things, so it would be better to start out with a binding
for each IP block. How many of these blocks are used for clocks, and
what do they do?

Arnd


\
 
 \ /
  Last update: 2014-10-10 12:42    [W:0.077 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site