Messages in this thread | | | Date | Fri, 10 Oct 2014 11:30:31 +0200 | From | Arend van Spriel <> | Subject | Re: [PATCH] bcma: Add dependency on OF_ADDRESS |
| |
On 10/09/14 23:48, Hauke Mehrtens wrote: > On 10/09/2014 09:25 PM, Guenter Roeck wrote: >> On Thu, Oct 09, 2014 at 08:28:31PM +0200, Hauke Mehrtens wrote: >>> On 10/09/2014 07:29 PM, Guenter Roeck wrote: >>>> On Thu, Oct 09, 2014 at 07:18:31PM +0200, Arend van Spriel wrote: >>>>> On 10/09/14 19:15, Arend van Spriel wrote: >>>>>> On 10/09/14 18:54, Rafał Miłecki wrote: >>>>>>> On 9 October 2014 18:41, Guenter Roeck<linux@roeck-us.net> wrote: >>>>>>>> Commit 2101e533f41a ("bcma: register bcma as device tree driver") >>>>>>>> introduces a hard dependency on OF_ADDRESS into the bcma driver. >>>>>>>> OF_ADDRESS is specifically disabled for the sparc architecture. >>>>>>>> This results in the following error when building sparc64:allmodconfig. >>>>>> >>>>>> Does this mean on sparc (using allmodconfig) you will get CONFIG_OF and >>>>>> !CONFIG_OF_ADDRESS? Does that makes sense? >>>>> >>>>> Is CONFIG_OF is used on sparc to access OpenBoot information? >>>>> >>>> I have no idea. All I know is that the driver doesn't build anymore with OF >>>> enabled and OF_ADDRESS disabled. >>> >>> Device tree support in bcma is only needed on some SoC, when this is >>> used on a PCIe card it is not needed. >>> >>> I would just deactivate the parts that are using device tree in bcma >>> when it is not available. I will send a patch after having something to eat. >>> >> Devicetree dependency is already covered with #ifdef CONFIG_OF. Problem is >> that it really needs #ifdef CONFIG_OF_ADDRESS. Though even that might be >> better than my patch, since it would at least build the driver on sparc >> as it used to do. >> >>> Is there a better method which is compatible with SPARC than using >>> of_translate_address() to get the reg address and also take the ranges >>> attribute of the bus into account? >>> >> No idea, sorry. Can you by any chance use pcie device information >> instead of depending on devicetree data ? > > Device tree is not used for PCIe devices in bcma. We only use it when > bcma is used for the system bus on some Broadcom SoCs, currently there > is no plan to use device tree for PCIe devices in bcma. I think bcma is > only used on wifi cards connected via PCIe on Sparc systems.
When we mainlined I verified the brcmsmac was working on a sparc system. However, at that time we were not using BCMA. I do not recall whether or not we tested on sparc with BCMA support. I might give it a spin again.
Regards, Arend -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |