lkml.org 
[lkml]   [2014]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2 03/17] powerpc/cell: Make spu_flush_all_slbs() generic
    Date
    On Tue, 2014-30-09 at 10:34:52 UTC, Michael Neuling wrote:
    > diff --git a/arch/powerpc/include/asm/copro.h b/arch/powerpc/include/asm/copro.h
    > index 2858108..f3d338f 100644
    > --- a/arch/powerpc/include/asm/copro.h
    > +++ b/arch/powerpc/include/asm/copro.h
    > @@ -15,4 +15,10 @@ int copro_handle_mm_fault(struct mm_struct *mm, unsigned long ea,
    >
    > int copro_data_segment(struct mm_struct *mm, u64 ea, u64 *esid, u64 *vsid);
    >
    > +
    > +#ifdef CONFIG_PPC_COPRO_BASE
    > +void copro_flush_all_slbs(struct mm_struct *mm);
    > +#else
    > +#define copro_flush_all_slbs(mm) do {} while(0)

    This can be a static inline, so it should be. That way you get type checking on
    the argument for CONFIG_PPC_COPRO_BASE=n.


    cheers


    \
     
     \ /
      Last update: 2014-10-01 09:41    [W:4.073 / U:0.292 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site