Messages in this thread | | | Date | Wed, 1 Oct 2014 13:16:33 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH] mm, compaction: using uninitialized_var insteads setting 'flags' to 0 directly. |
| |
On Tue, 30 Sep 2014, Vlastimil Babka wrote:
> On 09/29/2014 05:30 AM, Xiubo Li wrote: > > Setting 'flags' to zero will be certainly a misleading way to avoid > > warning of 'flags' may be used uninitialized. uninitialized_var is > > a correct way because the warning is a false possitive. > > Agree. > > > Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com> > > Acked-by: Vlastimil Babka <vbabka@suse.cz> >
I thought we just discussed this when mm-compaction-fix-warning-of-flags-may-be-used-uninitialized.patch was merged and, although I liked it, it was stated that we shouldn't add any new users of uninitialized_var().
| |