Messages in this thread | | | Date | Wed, 1 Oct 2014 21:01:52 +0200 (CEST) | From | Jiri Kosina <> | Subject | Re: [PATCH] HID: uHID: fix excepted report type |
| |
On Wed, 1 Oct 2014, David Herrmann wrote:
> > diff --git a/drivers/hid/uhid.c b/drivers/hid/uhid.c > > index f6ec5ea..e094c57 100644 > > --- a/drivers/hid/uhid.c > > +++ b/drivers/hid/uhid.c > > @@ -154,7 +154,7 @@ static int __uhid_report_queue_and_wait(struct uhid_device *uhid, > > > > spin_lock_irqsave(&uhid->qlock, flags); > > *report_id = ++uhid->report_id; > > - uhid->report_type = ev->type; > > + uhid->report_type = ev->type + 1; > > Nice catch. We always need the *_REPLY type as response: > > Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Applied, thanks.
-- Jiri Kosina SUSE Labs
| |