Messages in this thread | | | Date | Wed, 1 Oct 2014 10:27:20 -0700 | Subject | Re: [PATCH] serial/core: Initialize the console pm state | From | Kevin Hilman <> |
| |
On Sun, Sep 21, 2014 at 11:30 PM, Sudhir Sreedharan <ssreedharan@mvista.com> wrote: > For console devices having UART_CAP_SLEEP capability, the uart_pm_state has > to be initialized to UART_PM_STATE_ON. Otherwise the LCR regiser values > are reinitialized when uart_change_pm is called from uart_configure_port. > > Signed-off-by: Sudhir Sreedharan <ssreedharan@mvista.com>
Multiple boot failures on ARM[1] were bisected down to this patch.
How was this patch tested, and on which platforms?
Also, the changelog states that this should be done only for UART_CAP_SLEEP, but the patch does it for every UART.
Greg, I suggest this patch be dropped from tty-next until it has been better described and tested.
Kevin
[1] http://lists.linaro.org/pipermail/kernel-build-reports/2014-October/005550.html
| |