lkml.org 
[lkml]   [2014]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2 02/17] powerpc/cell: Move data segment faulting code out of cell platform
    Date
    On Tue, 2014-30-09 at 10:34:51 UTC, Michael Neuling wrote:
    > From: Ian Munsie <imunsie@au1.ibm.com>
    >
    > __spu_trap_data_seg() currently contains code to determine the VSID and ESID
    > required for a particular EA and mm struct.
    >
    > This code is generically useful for other co-processors. This moves the code
    > of the cell platform so it can be used by other powerpc code. It also adds 1TB
    > segment handling which Cell didn't have.

    I'm not loving this.

    For starters the name "copro_data_segment()" doesn't contain any verbs, and it
    doesn't tell me what it does.

    If we give it a name that says what it does, we get copro_get_ea_esid_and_vsid().
    Or something equally ugly.

    And then in patch 10 you move the bulk of the logic into calculate_vsid().

    So instead can we:
    - add a small helper that does the esid calculation, eg. calculate_esid() ?
    - factor out the vsid logic into a helper, calculate_vsid() ?
    - rework the spu code to use those, dropping __spu_trap_data_seg()
    - use the helpers in the cxl code


    cheers


    \
     
     \ /
      Last update: 2014-10-01 09:21    [W:4.132 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site