lkml.org 
[lkml]   [2014]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next] et131x: Add PCIe gigabit ethernet driver et131x to drivers/net
From
Date
On Wed, 2014-10-01 at 14:45 +0200, Tobias Klauser wrote:
> On 2014-09-30 at 23:29:46 +0200, Mark Einon <mark.einon@gmail.com> wrote:
> > This adds the ethernet driver for Agere et131x devices to
> > drivers/net/ethernet.
[]
> > diff --git a/drivers/net/ethernet/agere/et131x.c b/drivers/net/ethernet/agere/et131x.c
[]
> > + rc = pci_enable_device(pdev);
> > + if (rc < 0) {
> > + dev_err(&pdev->dev, "pci_enable_device() failed\n");
> > + goto out;
>
> Nit: Just return rc here.

I don't think it matters at all.

It's a predictable style to use common exit blocks.

It's a maintainer's right to do it in whatever
fashion is desired.




\
 
 \ /
  Last update: 2014-10-01 16:21    [W:0.091 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site