lkml.org 
[lkml]   [2014]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V1] regulator: DA9211 : Fix a bug in update of mask bit
On Wed, Oct 01, 2014 at 01:02:27AM +0000, Opensource [James Seong-Won Ban] wrote:

> > Applied, but please try to make sure that your changelogs are more
> > descriptive - what is the bug? Please also use subject lines matching
> > the style for the subsystem.

> The proper operation of mask bit should be set as '0' for enabling the interrupt.
> The result of mask operation at previous code was the same to new one.
> But the meaning in the previous code was to set mask bit as '1'.

Right, the point is that this information should've gone in the
changelog - please bear this in mind for future patches.

> What is subject line you said?
> If you give me an example, it would be very helpful to me.

git shortlog drivers/regulator. The capitalisation and extra spaces are
both off.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-10-01 14:21    [W:1.567 / U:0.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site