lkml.org 
[lkml]   [2014]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH V3 Resend] cpufreq: create cpufreq_generic_get() routine
From
Hi Viresh,

On Mon, Jan 6, 2014 at 5:54 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> CPUFreq drivers that use clock frameworks interface,i.e. clk_get_rate(), to get
> CPUs clk rate, has similar sort of code used for most of them.
>
> This patch adds a generic ->get() which will do the same thing for them. All
> those drivers are required to now is to set .get to cpufreq_generic_get() and
> set their clk pointer in policy->clk during ->init().
>
> Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> Acked-by: Shawn Guo <shawn.guo@linaro.org>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> Acked-by: Shawn Guo <shawn.guo@linaro.org>
> Acked-by: Stephen Warren <swarren@nvidia.com>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> Rafael,
>
> V2->V3: As asked by you earlier, I have merged all 23 patches here as they had
> common log and were touching separate drivers. This is already acked by many
> people. Please see if looks okay for 3.14.

This patch breaks a bunch of ARM boards. In particular, the following
defconfigs no longer build:

assabet_defconfig
badge4_defconfig
cerfcube_defconfig
collie_defconfig
h3600_defconfig
hackkit_defconfig
jornada720_defconfig
lart_defconfig
neponset_defconfig
pleb_defconfig
shannon_defconfig
simpad_defconfig

Error is:

drivers/built-in.o: In function `cpufreq_generic_get':
drivers/cpufreq/cpufreq.c:189: undefined reference to `clk_get_rate'

Seems like this needs to be guarded by HAVE_CLK?


-Olof


\
 
 \ /
  Last update: 2014-01-09 10:01    [W:0.090 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site